[3.x] Add autocompletion for AnimatedSprite.play()
#60757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lawnjelly
reviewed
May 4, 2022
scene/2d/animated_sprite.cpp
Outdated
| void AnimatedSprite::get_argument_options(const StringName &p_function, int p_idx, List<String> *r_options) const { | ||
| if (p_idx == 0 && p_function == "play" && frames.is_valid()) { | ||
| const String quote_style = EDITOR_GET("text_editor/completion/use_single_quotes") ? "'" : "\""; | ||
| List<StringName> al; |
There was a problem hiding this comment.
I'm not very familiar with this but I noticed some of the other places in 3.x that do this, use this code:
#ifdef TOOLS_ENABLED
const String quote_style = EDITOR_GET("text_editor/completion/use_single_quotes") ? "'" : "\"";
#else
const String quote_style = "\"";
#endif
Is this necessary or does the EDITOR_GET work ok in non-tools builds?
There was a problem hiding this comment.
Ah, this whole get_argument_options() function is inside TOOLS_ENABLED, so it's not necessary to use the #ifdef.
I'm not sure if it's best practice. But I'm going to change it to use the #ifdef approach for the sake of consistency.
timothyqiu
force-pushed
the
animated-sprite-autocomplete-3.x
branch
from
8edc7c5 to
0f7f3d0
Compare
lawnjelly
approved these changes
May 5, 2022
akien-mga
approved these changes
May 5, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.xversion of #60756