Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocompletion for AnimatedSprite.play() #60756

Merged

Conversation

timothyqiu
Copy link
Member

Implements part of godotengine/godot-proposals#4463. I'm not sure if it's possible to add completion for the animation property.

I only tested this on 3.x because autocompletion on master has been kind of broken for me for a long time.

@timothyqiu timothyqiu requested review from a team as code owners May 4, 2022 13:10
@Calinou Calinou added this to the 4.0 milestone May 4, 2022
@Calinou Calinou added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 4, 2022
@Mickeon
Copy link
Contributor

Mickeon commented May 4, 2022

My eyes lit up when I saw this one, thank you!

Regarding the animation property, I could open a more general proposal about autocompleting properties when comparing or assigning, since I don't personally recall anything like that even existing in the Editor currently. It would be logic that plenty of properties would benefit from, not just animation.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 4, 2022
@timothyqiu timothyqiu force-pushed the animated-sprite-autocomplete branch from 11e9757 to 8d7d8ac Compare May 5, 2022 01:25
@timothyqiu timothyqiu force-pushed the animated-sprite-autocomplete branch from 8d7d8ac to 312ec61 Compare May 5, 2022 06:39
@akien-mga akien-mga merged commit f6e896a into godotengine:master May 5, 2022
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the animated-sprite-autocomplete branch May 5, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants