Fix path handling in FBX and Blend importers #59998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add the test project to https://github.com/godotengine/godot-tests? |
This was referenced Apr 7, 2022
fire
approved these changes
Apr 7, 2022
Probably not until next week, but I can try to do it then. The test case should just be to add the smallest possible .fbx and .blend files with weird names like shown above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59996 (confirmed buggy both on Linux and Windows, and fixed by this PR).
It's now successful with the following names:
It still fails with names that contain either
"or\n(as two characters, not an actual newline), but that's a pre-existing Godot bug in the import system which affects other importers too. Edit: Reported as #60000.