GeometryInstance: Remove unimplemented LOD properties #57196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove matching unimplemented VisualServer functions. Fixes godotengine#40784.
akien-mga
force-pushed
the
3.x-remove-unimplemented-lod
branch
from
4387645 to
33a2d65
Compare
akien-mga
commented
Jan 25, 2022
Comment on lines
-1572
to
-1575
| void VisualServerScene::instance_geometry_set_draw_range(RID p_instance, float p_min, float p_max, float p_min_margin, float p_max_margin) { | ||
| } | ||
| void VisualServerScene::instance_geometry_set_as_instance_lod(RID p_instance, RID p_as_lod_of_instance) { | ||
| } |
There was a problem hiding this comment.
For anyone curious, this is the core part where the implementation is missing. Everything else which is removed in this PR is just scaffolding to expose the feature that should be implemented here (but isn't).
lawnjelly
approved these changes
Jan 25, 2022
|
Note that there's a pull request implementing those LOD properties for It needs more work before it can be merged though. |
|
Well if it can be made to work that would be best indeed, it's better to solve non-working properties by making them work than by removing them for sure :) |
|
Closing as superseded by #53778, seems like the plan is that we can actually implement those properties eventually. Probably for 3.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove matching unimplemented VisualServer functions.
Fixes #40784.
Breaks compat because it removes methods from the API, so any code that was using them will now raise an error. But these methods did nothing, so there should be no logic regression in user games, the only impact is that some users mistakenly calling these methods might have to remove these no-op calls from their scripts.