Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched LOD not working again #57185

Closed
DimitriyPS opened this issue Jan 25, 2022 · 10 comments
Closed

Switched LOD not working again #57185

DimitriyPS opened this issue Jan 25, 2022 · 10 comments

Comments

@DimitriyPS
Copy link

DimitriyPS commented Jan 25, 2022

Godot version

3.5 b1

System information

All

Issue description

I read that Godot 3.5 will support LOD - I was delighted. But apparently this did not apply to switchable LODs. This feature worked in 2.x and already works in 4.x, i can only speculate, perhaps you could have this feature in version 3.5 as well? I humbly ask the development team for this small courtesy, unless of course it will embarrass you and will not be undue impudence on my part.
000

Steps to reproduce

  1. Create an object;
  2. Set distances;
  3. Rotate the mouse roller.

Minimal reproduction project

No response

@lawnjelly
Copy link
Member

lawnjelly commented Jan 25, 2022

There's no LOD in 3.x currently afaik (despite the settings in the UI being there).

@DimitriyPS
Copy link
Author

@lawnjelly why "feature proposal"?

I am not suggesting adding something new. It's there, but it doesn't work. If this is not a bug, then what is a bug?

@lawnjelly
Copy link
Member

lawnjelly commented Jan 25, 2022

I am not suggesting adding something new. It's there, but it doesn't work. If this is not a bug, then what is a bug?

Sorry to be more clear, this may be a language thing:

  • There is a setting that you can see in the user interface as shown in red on your screenshot. But this setting does nothing, it is probably leftover from Godot 2, or left for future expansion.
  • Code in the user interface is like the tip of an iceberg, it is not the functionality. The majority of the iceberg is under the water surface, and in this case, there is nothing under the surface, the other 99% of the code that does something has not been written.
  • In some sense the option appearing in the user interface is undesirable, which is why there's arguments either way whether to have the tag "bug". We could consider commenting this out (it may have been discussed in earlier issues). But nothing is actually broken in the code.

@akien-mga
Copy link
Member

This is a duplicate of #40784. Indeed there's no implementation behind these settings, they're leftovers from 2.x which never got reimplemented (and they're not easy to reimplement).

@DimitriyPS
Copy link
Author

I know it doesn't work (I've been waiting for LOD switches since version 3.0 for a very long time). I also understand that the code is not there.

But I checked, this functionality works in Godot 4. Godot 4 is very far from working. Therefore, now when many new developments began to be transferred from 4.x to 3.x, I hoped that this functionality could also be restored. I admit that I can be mistaken, but in theory, switching visibility based on the distance condition is a very simple technology.

@Zireael07
Copy link
Contributor

But I checked, this functionality works in Godot 4. Godot 4 is very far from working.

Not true (unless you're someone whose computer does NOT support Vulkan) - it does have its issues and porting a big project isn't easy, but Godot 4 definitely works.

Therefore, now when many new developments began to be transferred from 4.x to 3.x, I hoped that this functionality could also be restored.

If all you wanted to do was request a backport of the LOD from 4.x to 3.x, the issue should have been titled accordingly (the current title suggests a regression, which is not the case as it never worked in the first place)

@DimitriyPS
Copy link
Author

Not true (unless you're someone whose computer does NOT support Vulkan) - it does have its issues and porting a big project isn't easy, but Godot 4 definitely works.

I did not mean that Godot 4 does not start, I mean that it is too unstable for development using it.

If all you wanted to do was request a backport of the LOD from 4.x to 3.x, the issue should have been titled accordingly (the current title suggests a regression, which is not the case as it never worked in the first place)

Apparently I do not understand some of the subtleties. I see the same settings in Godot 2.x, 3.x and 4.x. But the technology only works in 2.x and 4.x.

So you are saying that I need to recreate the issue with a different title?

@akien-mga
Copy link
Member

akien-mga commented Jan 25, 2022

Apparently I do not understand some of the subtleties. I see the same settings in Godot 2.x, 3.x and 4.x. But the technology only works in 2.x and 4.x.

A setting is not a feature. Here's the implementation of visibility ranges in 4.0: #48847.

This is not trivial to backport, it depends on the renderer which is the main part which is 100% different in 2.x, 3.x, and 4.x. Rewriting the renderer is the main reason why these versions are not compatible with each other. It also mean that renderer-dependent features need to be reimplemented from scratch, and LOD was never reimplemented in 3.x. At this point, it's safe to assume it will not be.

The properties were left as an oversight and should be removed, which I do in #57196.

@DimitriyPS
Copy link
Author

It's clear. Thanks for the explanation. It's very unfortunate. This functionality is sorely lacking.

@akien-mga
Copy link
Member

Apparently there's a draft PR which implements the basic LOD functionality that could be expected from these properties: #53778.

So if it can be finalized, this would be merged instead of removing the properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants