Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease the default VoxelGI quality to improve performance #54677

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Nov 6, 2021

Follow-up to #49738 and #54158.

On a GeForce GTX 1080 in 2002×1447 resolution, decreasing VoxelGI quality from High to Low quality saves 1.2 ms of GPU time in a medium-sized test scene. This only results in a minor drop in quality.

This helps make the default VoxelGI performance more competitive with SDFGI (to the point where VoxelGI generally surpasses SDFGI now, which wasn't the case on my PC before).

Preview

High quality (current default)

2021-11-06_19 29 08

Low quality (new default)

2021-11-06_19 29 14

On a GeForce GTX 1080 in 2002×1447 resolution, decreasing VoxelGI quality
from High to Low quality saves 1.2 ms of GPU time in a medium-sized
test scene. This only results in a minor drop in quality.
@mrjustaguy
Copy link
Contributor

VoxelGI > SDFGI on lower end hardware (GTX 650 level for example), due to the cascade jumps making it unusable where VoxelGI runs Perfectly fine.
Yeah, SDFGI is good when the camera isn't getting translated, but when it is, it's the lows that matter, not the avg, so it isn't such a simple comparison between the 2

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in PR review meeting.

@akien-mga akien-mga merged commit 7332aff into godotengine:master Feb 10, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants