[3.x] Overhaul the theme editor and improve user experience #49774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
force-pushed
the
editor-theme-editor-overhaul-3.x
branch
from
3d6b67e
to
7120be9
Compare
akien-mga
approved these changes
Jun 21, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #49388 (including #49772).
Depends on #49512 being merged first.Rebased following the merge.It's the same except for the part about picking custom theme types from controls, as they don't exist in 3.x and cannot be backported to 3.x without breaking compatibility somewhat (see #47544). If at a future point we decide to backport #47544 in some form, this functionality can be easily restored by changing one line of code.