Revert backport of 2D transform and camera snapping options #46657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we're going this route, I'd ask to make the commit message a bit more explicit, e.g.: |
|
Yup sure, will do. 👍 |
lawnjelly
force-pushed
the
revert_snapping
branch
from
8a5ca82 to
8f33928
Compare
akien-mga
changed the title
|
Yes, just to make clear, this should be a good move because we can make the in progress functionality available in an addon in the meantime, so no one should miss out, and we should have a far more polished version for core. 👍 |
More work is needed to make sure that those options actually solve users' issues, so we prefer to remove the options for 3.2.4 and revisit for a future release.
lawnjelly
force-pushed
the
revert_snapping
branch
from
8f33928 to
bf1de6b
Compare
akien-mga
approved these changes
Mar 8, 2021
There was a problem hiding this comment.
As discussed on the Godot chat, there's still more work needed to make these reliable if we want them to be in the core engine. We'll keep working on these use cases and revisit for 3.2.5 and/or provide relevant addons/documentation on how to achieve what these snapping settings aim to provide.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #46615 (comment) I think there are a number of problem with
transform_snappingcurrently and we should leave this until 3.2.5.We can either mark the existing functions as experimental or revert, personally I'm in favour of reverting for 3.2.4, because I'm not keen on having broken functionality in stable release. Some might argue that the existing functions were helpful but we have to weigh that up against user confusion and expectations.