Fix Mono build after resource load cache changes #45959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Feb 13, 2021
| @@ -2,7 +2,7 @@ namespace Godot | |||
| { | |||
| public static partial class ResourceLoader | |||
| { | |||
| public static T Load<T>(string path, string typeHint = null, bool noCache = false) where T : class | |||
| public static T Load<T>(string path, string typeHint = null, ResourceLoader.CacheMode noCache = (ResourceLoader.CacheMode)1) where T : class | |||
There was a problem hiding this comment.
Not familiar with Mono bindings, but can't this use the actual enum value instead of casting 1? The whole point of enums is to avoid hardcoding magic numbers.
There was a problem hiding this comment.
I copied it from ResourceLoader that was generated by the engine (which mismatch with extension class caused an error). But yeah, probably a good idea to change it to actual enum.
Xartorx
force-pushed
the
fix-mono-load-cache
branch
from
9d08438 to
8e1da2e
Compare
akien-mga
approved these changes
Feb 13, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Mono build after resource load cache changes (#45903)