Don't emit changed signal on Color Picker close #44895
Conversation
KoBeWi
added
bug
topic:editor
cherrypick:3.x
|
Well, I think you should test it with VisualShader's Color constant node - when the color picker popup is going to close it should apply its color to the node. |
|
The color is updated even before the dialog is closed: |
|
Alright, then, I'm fine with it. |
| @@ -2191,7 +2187,6 @@ EditorPropertyColor::EditorPropertyColor() { | |||
| add_child(picker); | |||
| picker->set_flat(true); | |||
| picker->connect("color_changed", callable_mp(this, &EditorPropertyColor::_color_changed)); | |||
| picker->connect("popup_closed", callable_mp(this, &EditorPropertyColor::_popup_closed)); | |||
There was a problem hiding this comment.
There's now nothing connected to the popup_closed signal.
It used to be emitted when receiving modal_closed, which happens when the ColorPicker popup receives NOTIFICATION_MODAL_CLOSE. Are you sure that this doesn't trigger in situations where you might still want to validate the input?
There was a problem hiding this comment.
Are you sure that this doesn't trigger in situations where you might still want to validate the input?
That could only happen when you modify the color without triggering _color_changed() and then close the popup. AFAIK it's not possible.
|
Thanks! |
|
Cherry-picked for 3.2.4. |
akien-mga
removed
the
cherrypick:3.x
|
I think you've broke the visual shader color picker by doing this, visually it's indeed changed but if you switch the graph from vertex to fragment mode (for example) you will see that it's not true and the color still is white - so Color is not applied. |
I just noticed that #40879 is still not fixed (although I'm pretty sure I tested the PR). The culprit was the
_popup_closedmethod in EditorPropertyColor. It emitted the modified signal every time the color picker popup was closed, which is just dumb. Even if it was necessary for something, looks like_color_changed()is called anyways when the popup is closed, which resulted in doublesetcalls when the color was modified:btw I inspected the
_color_changed()call on close and it seems to be called with a slightly different color. Dunno what is it, maybe ColorPicker doesn't set proper RGB value and it's corrected (rounded?) on close.