Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing ColorPicker in the inspector always "modifies" the scene #40879

Closed
KoBeWi opened this issue Jul 30, 2020 · 1 comment · Fixed by #41002
Closed

Closing ColorPicker in the inspector always "modifies" the scene #40879

KoBeWi opened this issue Jul 30, 2020 · 1 comment · Fixed by #41002
Labels
bug topic:editor usability
Milestone
4.0

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Jul 30, 2020

Godot version:

3.2.3 rc2

Steps to reproduce:

  1. Create a Node2D
  2. Click on modulate to change color
  3. Don't change anything, just press Escape
  4. Scene was modified, bruh

It's annoying when you want to check/copy some color and it produces fake unsaved changes.
@AlphaOneProject AlphaOneProject mentioned this issue Aug 3, 2020
Merged
@AlphaOneProject
Copy link
Contributor

Hello,
I made this pull request resolving this issue on my side.
Could you please tell me if it is what you wanted?

I'm still beginning so I'm quite likely to have made mistakes, even if I did my best to follow the guidelines.

AlphaOneProject added a commit to AlphaOneProject/godot that referenced this issue Aug 3, 2020
@AlphaOneProject
Modify the scene only when color changed
f362636 
Editor now changes a color in the inspector only when it is different
from the current one.

Solves fake unsaved changes in editor after using the ColorPicker.

Resolves: godotengine#40879
@akien-mga akien-mga added this to the 4.0 milestone Aug 11, 2020
akien-mga pushed a commit to akien-mga/godot that referenced this issue Aug 13, 2020
@AlphaOneProject @akien-mga
Modify the scene only when color changed
3211a51 
Editor now changes a color in the inspector only when it is different
from the current one.

Solves fake unsaved changes in editor after using the ColorPicker.

Resolves: godotengine#40879
(cherry picked from commit f362636)
MarcusElg pushed a commit to MarcusElg/godot that referenced this issue Oct 19, 2020
@AlphaOneProject @MarcusElg
Modify the scene only when color changed
68ff1a8 
Editor now changes a color in the inspector only when it is different
from the current one.

Solves fake unsaved changes in editor after using the ColorPicker.

Resolves: godotengine#40879
huhund pushed a commit to huhund/godot that referenced this issue Nov 10, 2020
@AlphaOneProject
Modify the scene only when color changed
9b0b5a5 
Editor now changes a color in the inspector only when it is different
from the current one.

Solves fake unsaved changes in editor after using the ColorPicker.

Resolves: godotengine#40879
(cherry picked from commit f362636)
@KoBeWi KoBeWi mentioned this issue Jan 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Modify the scene only when color changed AlphaOneProject/godot
3 participants
@KoBeWi @akien-mga @AlphaOneProject