Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash duplicating local-to-scene resources [3.2] #43676

Closed
wants to merge 1 commit into from

Conversation

SaracenOne
Copy link
Member

Backport of this fix to the 3.2 branch (#43657)

@akien-mga
Copy link
Member

akien-mga commented Nov 19, 2020

That PR is already marked with cherrypick:3.2 label, so I will do the cherrypick.

Dedicated PRs to backport changes to 3.2 are fine when:

  • The master change is non-trivial to cherry-pick (merge conflicts, different API) and needs extensive testing.
  • It's done with git cherry-pick -x both to preserve authorship information and have a link to the original commit.

The normal workflow is that master PRs that are relevant for 3.2 get the cherrypick;3.2 label, and I do the cherry-picking myself (see e.g. #43456 or #43613 for recent examples).

@akien-mga akien-mga closed this Nov 19, 2020
@fire fire deleted the fix_dupe_crash_32 branch June 19, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants