Fix editor texture preview for certain specific dimensions #39638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jun 18, 2020
akien-mga
added
the
cherrypick:3.x
Ensures no error is issued when attempting to preview a resource that may be scaled down to <1 pixel when resizing to fit the thumbnail.
mrushyendra
force-pushed
the
editor_preview
branch
from
bfdc720 to
c7a8dc7
Compare
akien-mga
approved these changes
Jun 18, 2020
|
Thanks! |
|
Cherry-picked for 3.2.2. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, an error may be issued when showing a preview of a resource if
the associated image is resized to sub-1 pixel dimensions. This fix ensures no such error
is issued.
For example, when previewing a 256 x 1 PNG image:
After:
Figured that showing an image with 1-pixel width or height is better than not showing any
preview at all, though there may be a small distortion.
p_sizemust also already be size 1x1 orbigger, else a different error would be issued in the
rendering_server, so this should be safe.Closes #36940
(The same issue may also occur with the
EditorImagePreviewPlugin,EditorBitmapPreviewPluginandEditorMeshPreviewPlugin, though none seem to have been raised so far)Edit: Turns out it would also close #35662