Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export: Properly disable resource preview thread #35113

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Export: Properly disable resource preview thread #35113

merged 1 commit into from
Jan 14, 2020

Conversation

akien-mga
Copy link
Member

Fixes #26857.
Fixes #34433.
Fixes #34826.

Tested as working fine with p=x11 tools=yes and p=server tools=yes. Should also fix the bug for macOS and Windows tool builds.

@akien-mga akien-mga added this to the 3.2 milestone Jan 14, 2020
@akien-mga akien-mga merged commit 2f1be12 into godotengine:master Jan 14, 2020
@akien-mga akien-mga deleted the aint-no-peeking-for-command-lurkers branch January 14, 2020 11:13
@fire fire mentioned this pull request Jan 14, 2020
Closed
@akien-mga akien-mga mentioned this pull request Jan 14, 2020
Closed
@jamie-pate
Copy link
Contributor

#27963 is still broken after this change

Godot Engine v3.2.beta.custom_build.40f0649e5 - https://godotengine.org
reimport: begin: (Re)Importing Assets steps: 691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug topic:editor
Projects
None yet
Milestone
3.2
2 participants
@akien-mga @jamie-pate