Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non-resizeable windows to enter full-screen mode. #27490

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Allow non-resizeable windows to enter full-screen mode. #27490

merged 1 commit into from
Apr 9, 2019
+5 −1

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Mar 28, 2019

Makes window resizeable before entering full-screen, prevents changing sizeability while in full-screen and reverts it back on exiting full-screen.

Fixes #27464

@bruvzg bruvzg added this to the 3.2 milestone Mar 28, 2019
@reduz reduz requested a review from hpvb April 4, 2019 16:18
@akien-mga akien-mga merged commit 846e7bb into godotengine:master Apr 9, 2019
@akien-mga
Copy link
Member

Thanks!

@hpvb
Copy link
Member

hpvb commented Apr 20, 2019

Cherry-picked for 3.1.1.

@bruvzg bruvzg deleted the macos_non_resizable_fullscreen branch June 12, 2019 05:44
@bruvzg bruvzg mentioned this pull request Jul 2, 2020
Closed
@ebrahimebrahim ebrahimebrahim mentioned this pull request Sep 29, 2020
Open
@bruvzg bruvzg mentioned this pull request May 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpvb hpvb Awaiting requested review from hpvb

Assignees

@hpvb hpvb

Labels
enhancement platform:macos topic:porting
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

Fullscreen does not work on OSX when resizing is prohibited
3 participants
@bruvzg @akien-mga @hpvb