-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI elements ui_action usage, improvements #16947
Conversation
When line edit receive a up/down and the cursor is at beginning/end it will not set the input as handled
And id_focused to Popupmenu.
Used by Slider and Scrollbar
This fixes #16946. |
thanks, added it to the PR description so it should get closed automatically when merged |
Awesome. Thanks. |
I've tested this and it seems to work. I still have an issue where a popup panel does not react to any focus events on a keyboard. I try to find out if this is related or a separate issue. |
As no one seems to find the courage to merge this even though it's been tested and approved by a few, I'll abuse my newly acquired power and do it myself 😁 |
I'm sure there will be plenty of time to take the blame before |
Is there any chance to see these fixes in 3.0.3? |
May I also point to #18715 that I think is related? |
Hi @Faless, would you be open to revisiting this code to see if you can fix the issues with keyboard navigation that seemed to occur as a result of the "Tree now uses UI actions instead of key presses" changes? Assuming my assessment of the situation is correct, the issues have had a significant negative impact on the accessibility & usability of the Tree control both within the editor & third-party games/apps. There's some further details in #41014 & #36291. Thanks! |
When line edit receive a up/down and the cursor is at beginning/end it will not set the input as handled
ui_end
,ui_home
, used by Slider and Scrollbar (I can remove this if found useless)This is useful if for example you want to add UI sounds to your game.
Closes #16946
Closes #17159