Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI elements ui_action usage, improvements #16947

Merged
merged 7 commits into from
Mar 16, 2018
Merged

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Feb 23, 2018

  • Popupmenu now uses UI actions instead of key presses
  • Tree now uses UI actions instead of key presses
  • Line edit up/down focus pass through
    When line edit receive a up/down and the cursor is at beginning/end it will not set the input as handled
  • Properly sets input as handled when closing modal
  • Scrollbar now uses UI actions instead of key presses
  • Add two new default actions ui_end, ui_home, used by Slider and Scrollbar (I can remove this if found useless)
  • Add item_focused signal to OptionButton (and id_focused to PopupMenu)
    This is useful if for example you want to add UI sounds to your game.

Closes #16946
Closes #17159

@vnen
Copy link
Member

vnen commented Feb 23, 2018

This fixes #16946.

@Faless
Copy link
Collaborator Author

Faless commented Feb 23, 2018

thanks, added it to the PR description so it should get closed automatically when merged

@bfloch
Copy link
Contributor

bfloch commented Feb 23, 2018

Awesome. Thanks.

@bfloch
Copy link
Contributor

bfloch commented Mar 2, 2018

I've tested this and it seems to work.

I still have an issue where a popup panel does not react to any focus events on a keyboard. I try to find out if this is related or a separate issue.

@akien-mga akien-mga added this to the 3.1 milestone Mar 13, 2018
@Faless
Copy link
Collaborator Author

Faless commented Mar 16, 2018

As no one seems to find the courage to merge this even though it's been tested and approved by a few, I'll abuse my newly acquired power and do it myself 😁

@Faless Faless merged commit c531262 into godotengine:master Mar 16, 2018
@Faless
Copy link
Collaborator Author

Faless commented Mar 16, 2018

I'm sure there will be plenty of time to take the blame before 3.1 is out if something breaks 😼

@legione
Copy link

legione commented May 7, 2018

Is there any chance to see these fixes in 3.0.3?
I don't think these changes would break the compatibility and half of them are bugfixes anyway.

@legione
Copy link

legione commented May 10, 2018

May I also point to #18715 that I think is related?

@follower
Copy link
Contributor

follower commented Sep 3, 2021

Hi @Faless, would you be open to revisiting this code to see if you can fix the issues with keyboard navigation that seemed to occur as a result of the "Tree now uses UI actions instead of key presses" changes?

Assuming my assessment of the situation is correct, the issues have had a significant negative impact on the accessibility & usability of the Tree control both within the editor & third-party games/apps.

There's some further details in #41014 & #36291.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants