Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight Editor Settings categories #14549

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Highlight Editor Settings categories #14549

merged 1 commit into from
Dec 11, 2017

Conversation

RayKoopa
Copy link
Contributor

@RayKoopa RayKoopa commented Dec 11, 2017

Originating from https://github.com/godotengine/godot/issues/14380, but reusing already established design "standards" of other parts in the editor rather than new font style stuff.

  • Highlights Editor Settings category / parent items.
  • Made category tree a little wider to fully fit the "Window Placement" item into it.
  • Also hides the "interface/dialogs" category as manually configuring it doesn't make sense and is more irritating than useful (joke's on me, I introduced it some time ago). s. below

image

pi.name == "resource_name" ||
pi.name == "resource_path" ||
pi.name == "resource_local_to_scene" ||
pi.name.begins_with("interface/dialogs"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not meant to be edited by the user, it shouldn't be saved as editor settings IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's indirectly editable by moving and resizing windows. Would you still keep it then?
Editing the editor_settings_bounds while it's open doesn't work anyway and will be overriden when the window is closed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better remove that hardcoded skip (the other ones are related to the nature of PropertyEditor, not to the editor settings) for this PR, we can discuss how to handle those separately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to use some special PROPERTY_USAGE_ for those properties (like EDITOR but HIDDEN), but didn't find one. That would've been better than hardcoding it, I guess. I remove it for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that non-editable editor metadata should be saved in a file different from editor-settings-3.tres.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that possible atm and are there places where it has already been done (so I can steal code)? I created an issue to keep track of it.

@RayKoopa RayKoopa changed the title Highlight Editor Settings categories, hide Dialogs category Highlight Editor Settings categories Dec 11, 2017
@akien-mga akien-mga merged commit 36ce7c4 into godotengine:master Dec 11, 2017
@RayKoopa RayKoopa deleted the highlight_settings_categories branch December 12, 2017 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants