-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove irritating Interface > Dialogs category from Editor Settings #14550
Comments
Shouldn't we keep this information separate from the settings, for example alongside layouts? |
Interesting idea, I like it so far. |
If those should not be configurable, just "hardcode" the values in the editor code. |
I don't have such file, can you link to it? We previously discussed not to hardcode hiding them as linked above. |
Sorry I meant |
Then the whole category is useless, just displaying read-only values. Nah, that's still ugly IMHO. Get rid of them in the settings, there's already too much in them. |
Yeah, if you don't make them configurable, it means removing them from the settings... The category will be removed automatically once you removed all the properties inside it. |
Oh nice, I didn't know that it works like that exactly. What property usage do I have to specify then? |
I don't get what you mean. For example at line 144, instead of: But I'm not sure it could work like that, as the property may need to be global. |
And how are the window bounds stored and restored from settings if it's just a temporary field of the class? |
Reading the code, it might work by just putting an underscore before the property name. |
No, it still appears then. |
You could also put them in the project metadata file. ( |
It's saved per-project then, if I got that right, I'm not sure if that makes sense. Per-layout would make more sense, aka @bojidar-bg 's solution |
Yeah, probably that @bojidar-bg's proposal makes sense too. I'm allright with that. |
This appears to have been mostly resolved in the godot/editor/plugins/polygon_2d_editor_plugin.cpp Lines 266 to 270 in 4e0f31a
Once this last use has been removed and replaced with the new system (I don't know what it is), this issue can be closed. Edit: Still valid as of 4.0.alpha11. |
As discussed in #14549, I wanted to prevent the
interface/dialogs/*
settings to be visible in the Editor Settings because:editor_settings_bounds
doesn't work anyway as it is overridden when the Editor Settings window is closedI originally implemented hiding it in the PR linked above by skipping over the category with a hardcoded check for the name, but that's not a good solution as pointed out by @akien-mga .
How would I be able to hide such "indirectly useful but directly useless" settings from the Editor Settings without the need for hardcoding category names?
The text was updated successfully, but these errors were encountered: