-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ MAKE_TYPED_ARRAY does not include newer Variant types #87991
Closed
Labels
Milestone
Comments
|
Ah, thanks for the explanation! |
allenwp
added a commit
to allenwp/godot-cpp
that referenced
this issue
Feb 6, 2024
This is a companion commit to the godot PR godotengine/godot#87992 which fixes godotengine/godot#87991
allenwp
added a commit
to allenwp/godot-cpp
that referenced
this issue
Feb 6, 2024
This is a companion commit to the godot PR godotengine/godot#87992 which fixes godotengine/godot#87991
allenwp
added a commit
to allenwp/godot-cpp
that referenced
this issue
Feb 6, 2024
This is a companion commit to the godot PR godotengine/godot#87992 which fixes godotengine/godot#87991
allenwp
added a commit
to allenwp/godot-cpp
that referenced
this issue
Feb 6, 2024
This is a companion commit to the godot PR godotengine/godot#87992 which fixes godotengine/godot#87991 Also syncs up change from godot to undefine typed array templates after use.
allenwp
added a commit
to allenwp/godot-cpp
that referenced
this issue
Feb 6, 2024
This is a companion commit to the godot PR godotengine/godot#87992 which fixes godotengine/godot#87991 Also undefines typed array templates after use to match Godot's typed_array.h
enetheru
pushed a commit
to enetheru/godot-cpp
that referenced
this issue
Mar 12, 2024
This is a companion commit to the godot PR godotengine/godot#87992 which fixes godotengine/godot#87991 Also undefines typed array templates after use to match Godot's typed_array.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tested versions
4.2.1 tag, current master ( d335281 )
System information
N/A
Issue description
typed_array.h
has a number of lines that use theMAKE_TYPED_ARRAY
macro for almost allVariant
types. This was introduced back in 2020. But when theVECTOR4
,VECTOR4I
, andPROJECTION
types were added, it seems that this list was never updated to include them.godot/core/variant/typed_array.h
Lines 91 to 132 in d335281
This means that it is not possible to write something like this:
TypedArray<Vector4>
...even though it is possible to write this:
TypedArray<Vector3>
I also noticed that the
OBJECT
type was never included in this list. I can only presume this was an intentional omission...?Steps to reproduce
Try to compile
TypedArray<Vector4> my_array;
. Note that this results in this compile error:typed_array.hpp(53): error C2039: 'get_class_static': is not a member of 'godot::Vector4'
Minimal reproduction project (MRP)
N/A
The text was updated successfully, but these errors were encountered: