Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening member description in docs causes extra navigation #82292

Closed
aXu-AP opened this issue Sep 25, 2023 · 1 comment · Fixed by #82498
Closed

Opening member description in docs causes extra navigation #82292

aXu-AP opened this issue Sep 25, 2023 · 1 comment · Fixed by #82498
Labels
bug discussion topic:editor topic:gui
Milestone
4.3

Comments

@aXu-AP
Copy link
Contributor

aXu-AP commented Sep 25, 2023

Godot version

v4.2.dev5.official [e3e2528] (or any 4.x)

System information

Windows 10

Issue description

Whenever I open a member/method description from ctrl+clicking them in script or from inspector, if the docs page wasn't already opened, 2 navigation events happen: first, the page opens, then it goes to the selected anchor. Ie. pressing back button doesn't take you where you were, but to the top of the page.
docs

Steps to reproduce

  1. Open any scene with some node and/or script in it.
  2. Ensure that selected node's doc page isn't opened yet in docs.
  3. Open docs either from right clicking a member in inspector or ctrl+clicking in code.

Minimal reproduction project

N/A
@aXu-AP aXu-AP mentioned this issue Sep 25, 2023
Closed
@dalexeev
Copy link
Member

This may be due to the fact that the page takes some time to load (RichTextLabel in Editor Help uses threading). Try opening a large page like ProjectSettings and you'll see a loading bar. That is, the visual jump is not a bug, but a limitation. But this should not create a point in the navigation history (I am not aware if such a system exists).

@aXu-AP aXu-AP mentioned this issue Sep 28, 2023
Merged
@akien-mga akien-mga added this to the 4.3 milestone Jan 9, 2024
GuybrushThreepwood-GitHub pushed a commit to GuybrushThreepwood-GitHub/godot that referenced this issue Jan 27, 2024
@aXu-AP @GuybrushThreepwood-GitHub
Fix opening docs writing extra navigation history
a4e817e 
Fix godotengine#82292
Removes extraneous call to change the tab if the page wasn't yet open when opening class member description.
akien-mga pushed a commit to akien-mga/godot that referenced this issue Mar 11, 2024
@aXu-AP @akien-mga
Fix opening docs writing extra navigation history
a05e159 
Fix godotengine#82292
Removes extraneous call to change the tab if the page wasn't yet open when opening class member description.

(cherry picked from commit 0506d6f)
@Maran23 Maran23 mentioned this issue Sep 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug discussion topic:editor topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Fix opening docs writing extra navigation history aXu-AP/godot
3 participants
@aXu-AP @akien-mga @dalexeev