Font is rendered different in Label and RichtTextLabel

[letsgamedev]

Godot version:
v3.1.alpha.calinou.10e9221

OS/device including version:
Mac 10.14.1

Issue description:
Okay, in total this is a lot of stuff, I guess. But first things first.

The upper one is a Label and the lower one is a RichTextLabel. Both with the same Font but there looking different. Font size is the same and af far as I know every font related is the same (default values)

I really like the Line Skipped param in the Label, but that is not available in the RichTextLabel.
On the other side, I want to colorize words with [color=red]foo[/color] but bb_code is only possible on RichTextLabels.

Also, are there some plans to integrate some of those special Text effects like Game Maker Studio show here?

Looks like this is more a feature request than a bug report.

[volzhs]

would you attach the sample project reproduce it?

[letsgamedev]

GitHubExample_fonts.zip

In this clean example, the font doesn't look so odd as in my screenshot above. But it looks different in detail.

[girng]

odd. this is how it looks on w10, 64-bit, gtx 950. regarding your bbcode effect question, this has a possibility of being merged

[letsgamedev]

The lower has a different white tone. Or is there a different default text color for RichTextLabels? But the more important: The text effects from the other tickets are great! Exactly what we looked for!

[girng]

The lower has a different white tone. Or is there a different default text color for RichTextLabels? But the more important: The text effects from the other tickets are great! Exactly what we looked for!

yeah seems like the label version (top) is a bit brighter. font settings are exactly the same on each... weird

[volzhs]

it's because of default theme.
Default color for RichTextLabel is set here.

godot/scene/resources/default_theme/default_theme.cpp

Line 796 in 10e9221

theme->set_color("default_color", "RichTextLabel", control_font_color);

and the control_font_color value is here

godot/scene/resources/default_theme/default_theme.cpp

Line 180 in 10e9221

Color control_font_color = Color::html("e0e0e0");

seems not a bug but prefer settings for default theme.
you can see the same white text when setting Custom Colors > Default Color to white.

[girng]

thanks @volzhs

@letsgamedev looks like the letter spacing thing might still be a bug. but i don't have a mac and can't replicate that issue on windows

[Eoin-ONeill-Yokai]

@letsgamedev
There's a patch currently on the works (my own) that was linked above. ( #23658 ) It's still under development and consideration -- any feedback or visual resources for effects that might be desired would be useful for me to try to improve the api. Scaling (like in the video above) is not currently in my patch, for instance. I will look into adding features like that in the near future. Please provide any more examples of interesting text effects in my pull request.

It is worth noting that some text rendering attributes in Label vs RichTextLabel are different, so things like wrapping and kerning can have some differences between the two classes. To be blunt, I think that the RichTextLabel class does need to have some work done to it in order to improve the rendering to be more consistent and cleaner. A general clean up of the class would be nice, but is not urgent.

[letsgamedev]

Whats about the Lines Skipped feature like in the Label Element? Shall I make an extra Feature request for that. For me this is very handy to use in Textboxes.

[txigreman]

I've uploaded a Sample Project to the bug report #25127 where the spacing issue can be seen clearly.

[txigreman]

In case it helps: I noticed that, in my attached demo project, Label and RichTextLabel behave the same if font size is set to 7:

If I set the font size to any smaller number the mess begins:

With a bigger size they do not look as bad as before, but they still do not look the same:

[wagnerfs]

Just curious about this one still, I had to stop my game since I need bbcode going and the resolution is too small and make this bug a hell to work with.
I suppose I could also fool around with the RichTextLabel implementation to see if I can get a fix for it, just asking to check if someone else already gave it some thoughts.

[Eoin-ONeill-Yokai]

I just got back from an overseas trip to the Krita sprint in the Netherlands. While I prepare my pr with necessary revisions, I will promise to investigate this a little bit.

My guess would be that the font renderer "instance" is configured slightly differently between the two classes. I can't make any promises that I'll find the specific issue, but I'll try to see if there's anything that stands out.

[volzhs]

I tested this with 3.1.2-devel a5082c0

seems fixed...

[txigreman]

I've tried it out in the nighly build from hugo.pro and the problem still persists.

Both components behave the same in the editor, but they do behave different when running the project.

[wagnerfs]

Same here, still goes crazy while running, even a working font size will freak out once you dynamically (or set a custom size even) resize the window.
What's intriguing is that it used to work normally on 3.0 and even 2.1.5.

[Calinou]

Same here, still goes crazy while running, even a working font size will freak out once you dynamically (or set a custom size even) resize the window.
What's intriguing is that it used to work normally on 3.0 and even 2.1.5.

This could be due to font oversampling, which is enabled by default since 3.1. Does disabling Rendering > Quality > Dynamic Fonts > Use Oversampling solve the issue?

[wagnerfs]

Same here, still goes crazy while running, even a working font size will freak out once you dynamically (or set a custom size even) resize the window.
What's intriguing is that it used to work normally on 3.0 and even 2.1.5.

This could be due to font oversampling, which is enabled by default since 3.1. Does disabling Rendering > Quality > Dynamic Fonts > Use Oversampling solve the issue?

Yeah, it fixed the issue completely, so it was probably that all along, thanks a bunch, I can finally resume the game!

[Calinou]

@wagnerfs Good to know 🙂

I believe the bug related to font oversampling is tracked in #22580.

[Calinou]

I'll close this in favor of #22580, as it tracks the remaining issue with RichTextLabel sizing when font oversampling is enabled.