Skip to content

Commit

Permalink
Merge pull request #94413 from rburing/fix_action_press_tick
Browse files Browse the repository at this point in the history
Fix physics tick count in `Input.action_press` and `Input.action_release`
  • Loading branch information
akien-mga committed Jul 17, 2024
2 parents cb2650c + b41ec93 commit 59737bf
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions core/input/input.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -890,8 +890,9 @@ void Input::action_press(const StringName &p_action, float p_strength) {
// Create or retrieve existing action.
ActionState &action_state = action_states[p_action];

// As input may come in part way through a physics tick, the earliest we can react to it is the next physics tick.
if (!action_state.cache.pressed) {
action_state.pressed_physics_frame = Engine::get_singleton()->get_physics_frames();
action_state.pressed_physics_frame = Engine::get_singleton()->get_physics_frames() + 1;
action_state.pressed_process_frame = Engine::get_singleton()->get_process_frames();
}
action_state.exact = true;
Expand All @@ -908,7 +909,8 @@ void Input::action_release(const StringName &p_action) {
action_state.cache.pressed = 0;
action_state.cache.strength = 0.0;
action_state.cache.raw_strength = 0.0;
action_state.released_physics_frame = Engine::get_singleton()->get_physics_frames();
// As input may come in part way through a physics tick, the earliest we can react to it is the next physics tick.
action_state.released_physics_frame = Engine::get_singleton()->get_physics_frames() + 1;
action_state.released_process_frame = Engine::get_singleton()->get_process_frames();
action_state.device_states.clear();
action_state.exact = true;
Expand Down

0 comments on commit 59737bf

Please sign in to comment.