Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Skeleton modifier design article #854

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented May 26, 2024

SkeletonModifier3D was implemented by godotengine/godot#87888 with some Skeleton processes reworking. This article is intended to help community users understand the modification process and enable them to develop custom IK, physical bone and etc.

@TokageItLab TokageItLab force-pushed the skeleton-modifier branch 2 times, most recently from bb651b6 to 9d52afb Compare May 26, 2024 19:38
@Calinou Calinou added the topic:blog New blogposts and corrections label May 26, 2024
@TokageItLab TokageItLab force-pushed the skeleton-modifier branch 4 times, most recently from cc123f1 to 7a09afc Compare June 2, 2024 21:55
@TokageItLab TokageItLab marked this pull request as ready for review June 2, 2024 21:55
@TokageItLab TokageItLab force-pushed the skeleton-modifier branch 9 times, most recently from e5cc294 to bd89ce0 Compare June 9, 2024 06:36
@TokageItLab
Copy link
Member Author

TokageItLab commented Jun 9, 2024

I added a tutorial about creating a custom SkeletonModifier3D. Note that it depends on the following two PRs. So those must be merged before publishing this article.

@TokageItLab TokageItLab force-pushed the skeleton-modifier branch 7 times, most recently from 2655fce to 1628388 Compare June 10, 2024 01:32
@TokageItLab
Copy link
Member Author

@clayjohn @coppolaemilio May I request proofreading for publication?

@TokageItLab TokageItLab force-pushed the skeleton-modifier branch 2 times, most recently from 4d8163f to 4e2a385 Compare July 7, 2024 00:45
@clayjohn
Copy link
Member

clayjohn commented Jul 8, 2024

I will try to review this shortly!

@adamscott
Copy link
Member

As we're using .webp for serving images, we should use .webm for serving videos.

@TokageItLab
Copy link
Member Author

TokageItLab commented Jul 15, 2024

@adamscott I think webm may not play on some apple devices (iOS). Besides, we still use mp4 in our recent articles (such as godot-4-2-beta release article).

@Calinou
Copy link
Member

Calinou commented Jul 15, 2024

I think webm may not play on some apple devices (iOS)

Both VP8 and VP9 WebM are supported since iOS 17.4: https://caniuse.com/webm
Other browsers (including macOS Safari) have had WebM support for a much longer time.

godot-docs have started to use it, e.g. on Prototyping levels with CSG.

VP9 is more efficient than H.264, so we should use it to save on bandwidth.

@TokageItLab
Copy link
Member Author

Replaced.

@adamscott
Copy link
Member

Besides, we still use mp4 in our recent articles (such as godot-4-2-beta release article).

😰

@Calinou
Copy link
Member

Calinou commented Jul 15, 2024

Besides, we still use mp4 in our recent articles (such as godot-4-2-beta release article).

😰

We can (and should) keep using H.264 on existing pages, as converting the videos from a lossy format to another will further decrease quality with no gains in efficiency. We don't have lossless sources for those videos that we could re-encode in VP9.

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I just did an English language pass to help clarify things.

I did not review the images or code in depth

collections/_article/design-of-the-skeleton-modifier-3d.md Outdated Show resolved Hide resolved
collections/_article/design-of-the-skeleton-modifier-3d.md Outdated Show resolved Hide resolved
collections/_article/design-of-the-skeleton-modifier-3d.md Outdated Show resolved Hide resolved
collections/_article/design-of-the-skeleton-modifier-3d.md Outdated Show resolved Hide resolved
collections/_article/design-of-the-skeleton-modifier-3d.md Outdated Show resolved Hide resolved
collections/_article/design-of-the-skeleton-modifier-3d.md Outdated Show resolved Hide resolved
collections/_article/design-of-the-skeleton-modifier-3d.md Outdated Show resolved Hide resolved
collections/_article/design-of-the-skeleton-modifier-3d.md Outdated Show resolved Hide resolved
collections/_article/design-of-the-skeleton-modifier-3d.md Outdated Show resolved Hide resolved
collections/_article/design-of-the-skeleton-modifier-3d.md Outdated Show resolved Hide resolved
@TokageItLab
Copy link
Member Author

TokageItLab commented Aug 8, 2024

@clayjohn Thank you very much! I have looked at each of the proposals, and I believe it is very fine, as no change of intent has been made.

@TokageItLab TokageItLab requested review from fire and clayjohn August 8, 2024 08:34
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks good to me, I haven't reviewed the images but I am sure they are great

@TokageItLab TokageItLab force-pushed the skeleton-modifier branch 3 times, most recently from 5a7e964 to 81d1869 Compare August 9, 2024 21:37
@coppolaemilio coppolaemilio merged commit cdbd881 into godotengine:master Aug 12, 2024
1 check passed
@coppolaemilio
Copy link
Member

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:blog New blogposts and corrections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no PhysicalBone3D/SkeletonModifier3D migration document
6 participants