-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Skeleton modifier design article #854
Add Skeleton modifier design article #854
Conversation
bb651b6
to
9d52afb
Compare
cc123f1
to
7a09afc
Compare
7a09afc
to
46bcbaf
Compare
e5cc294
to
bd89ce0
Compare
I added a tutorial about creating a custom SkeletonModifier3D. Note that it depends on the following two PRs. So those must be merged before publishing this article. |
2655fce
to
1628388
Compare
1628388
to
8747bd4
Compare
8747bd4
to
bcf5158
Compare
@clayjohn @coppolaemilio May I request proofreading for publication? |
4d8163f
to
4e2a385
Compare
I will try to review this shortly! |
As we're using .webp for serving images, we should use .webm for serving videos. |
@adamscott I think webm may not play on some apple devices (iOS). Besides, we still use mp4 in our recent articles (such as godot-4-2-beta release article). |
Both VP8 and VP9 WebM are supported since iOS 17.4: https://caniuse.com/webm godot-docs have started to use it, e.g. on Prototyping levels with CSG. VP9 is more efficient than H.264, so we should use it to save on bandwidth. |
4e2a385
to
2472b8b
Compare
Replaced. |
😰 |
We can (and should) keep using H.264 on existing pages, as converting the videos from a lossy format to another will further decrease quality with no gains in efficiency. We don't have lossless sources for those videos that we could re-encode in VP9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I just did an English language pass to help clarify things.
I did not review the images or code in depth
7babe5e
to
0cbf9bd
Compare
@clayjohn Thank you very much! I have looked at each of the proposals, and I believe it is very fine, as no change of intent has been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text looks good to me, I haven't reviewed the images but I am sure they are great
5a7e964
to
81d1869
Compare
Co-authored-by: Clay John <[email protected]>
81d1869
to
46cb1de
Compare
Thank you so much! |
SkeletonModifier3D was implemented by godotengine/godot#87888 with some Skeleton processes reworking. This article is intended to help community users understand the modification process and enable them to develop custom IK, physical bone and etc.