Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no PhysicalBone3D/SkeletonModifier3D migration document #94831

Closed
Kovacs-3d opened this issue Jul 27, 2024 · 3 comments · Fixed by godotengine/godot-website#854
Closed

Comments

@Kovacs-3d
Copy link

Kovacs-3d commented Jul 27, 2024

Tested versions

Reproducible in v4.3.rc1.official [e343dbb], v4.3.rc1.mono.official [e343dbb], 4.3 beta 3

System information

Godot v4.3.rc1 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (NVIDIA; 31.0.15.5186) - 12th Gen Intel(R) Core(TM) i5-12600K (16 Threads)

Issue description

In 4.2 it works great, but unfortunately in 4.3 it's completely broken. I tried several settings with PhysicalBoneSimulator3D and I also tried enabling Deprecated animate_physical_bones in Skeleton3D.
The angular velocity may be the problem. How should it be set to get it right? Could it be a bug?
The script was based on this tutorial:
https://www.youtube.com/watch?v=0MHY2TDeMLM

Here Godot 4.2 work version video:

4.2_work.mp4

And this video shows the 4.3 non-functional version.

4.3_not_work.mp4

Steps to reproduce

1.Open active_ragdoll_4.3.zip using v4.3.rc1.official [e343dbb] or v4.3.rc1.mono.official [e343dbb],Run,wait 1 second
2.Open active_ragdoll_4.2.zip using v4.2.2.stable.mono.official [15073af],Run,wait 1 second
3.Compare the differences between the two

Minimal reproduction project (MRP)

active_ragdoll_4.3.zip
active_ragdoll_4.2.zip

@akien-mga
Copy link
Member

CC @TokageItLab

@TokageItLab
Copy link
Member

This is never a bug. Here is fixed project active_ragdoll_4.3_fixed.zip.

Poses modified by SkeletonModifier should be retrieved in the signal. Documentation on this godotengine/godot-website#854 has already been written but not yet proofed and merged. cc @clayjohn @adamscott

@TokageItLab TokageItLab removed this from the 4.3 milestone Jul 29, 2024
@TokageItLab TokageItLab changed the title [4.3 RC1, beta 3] Active Ragdoll PhysicalBone3D (GD 4.2 work perfect 4.3 it's completely broken) There is no PhysicalBone3D/SkeletonModifier3D migration document Jul 29, 2024
@Kovacs-3d
Copy link
Author

Thank you, and sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants