Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a consistent name to Godot's shading language #4350

Closed
DeeJayLSP opened this issue Apr 5, 2022 · 4 comments · May be fixed by godotengine/godot#97298
Closed

Give a consistent name to Godot's shading language #4350

DeeJayLSP opened this issue Apr 5, 2022 · 4 comments · May be fixed by godotengine/godot#97298

Comments

@DeeJayLSP
Copy link

DeeJayLSP commented Apr 5, 2022

Describe the project you are working on

A long term game project that, of course, makes use of shaders.

Describe the problem or limitation you are having in your project

It feels like we're working with a shading language that doesn't have a name, or is named "shader", "shaders" or "Godot". There's no consistent name for the language in the editor or the docs.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Formally give a proper name to Godot's shading language, even if it's the long "Godot Shader Language". Short forms could also be considered.

(I'm aware that .shader files are now .gdshader in 4.0, so maybe that could be considered as a short form).

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

In the documentation, bits of text that look like these:

In Godot, all shaders start with a line specifying what type of shader they are.
Shaders style guide

Would look like these:

In <the chosen language name>, all shaders start with a line specifying what type of shader they are.
<Chosen language name> style guide

(These bits have actually been taken from the docs)

If this enhancement will not be used often, can it be worked around with a few lines of script?

This is a naming change (or should I say addition) so it's not code related.

Is there a reason why this should be core and not an add-on in the asset library?

You can't do a core naming change through an add-on.

@Calinou
Copy link
Member

Calinou commented Apr 5, 2022

Related to #4334.

@tetrapod00
Copy link

Updated, more specific proposal #10784.

@Mickeon
Copy link

Mickeon commented Sep 21, 2024

We may want to close this proposal in favour of the latter

@Calinou
Copy link
Member

Calinou commented Sep 22, 2024

Closing in favor of #10784.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants