-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formally rename the Godot shading language to "GDShader" #10784
Comments
That is probably the best name indeed, as its pattern matches not just "GDScript", but also "GDNative" and "GDExtension". |
I certainly prefer "GDShader" over "GDSL" considering there's no risk of confusing it with GLSL. |
This is kind of one of those suggestions everyone is thinking about, but no one feels like saying. The rapid number of upvotes in a short span of time should speak for itself. |
See also #2488 and godotengine/godot#47336 for some additional context from when the file extension was renamed from |
In my case, I'll fully admit I've been using the name "GDShader" on purpose whenever I open issues or talk about it in chat, precisely to try to push towards this convention. Because I know conventions are often made bottom-up instead of top-down. "Vai que cola" mentality 😆 (i.e. sneakily throw an idea to see if it sticks) Btw, not trying to claim credit for it or anything, I just think it's funny that I've been doing this, and now feel like a villain (MHUAHAHAHAHA! YOU FELL FOR IT! IT'S IN YOUR SUB-CONSCIOUSNESS NOW! 😈 ) |
Just opened a PR for the editor. |
Opened a PR for the manual: godotengine/godot-docs#9984. |
Describe the project you are working on
Writing shaders.
Writing godot docs.
Teaching godot shaders in community channels.
Describe the problem or limitation you are having in your project
Godot's shader language currently has no official name, being referred to variously as "the Godot Shader Language", "Godot's shading language", or colloquially as "GDShader" after the file extension.
"Godot's shader language" and "the Godot Shader langauge" are now slightly ambiguous. GLSL can now be considered one of "Godot's shader languages", since it is used for compute shaders and compositor effects.
We don't call GDScript "Godot's scripting language" . We should give it's shading language the same respect.
See the original discussion: #4334.
Describe the feature / enhancement and how it helps to overcome the problem or limitation
See discussion in #4334.
Make the official name of Godot's shading lanuage "GDShader", to match the naming of "GDScript".
This already has some level of adoption in the wild since the file extension was renamed to
.gdshader
(see linked discussion). I personally call it "GDShader" whenever I'm describing the differences to someone who is already familiar with GLSL.Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams
Change some core references to "Godot's shading language" or "Godot shaders" in the docs. Probably change Shading Language/Introduction, the Shader class reference, and the GLSL Migration Guide. In places like compute shaders where godot does use GLSL, we would make the distinction that "GLSL is used, not GDShader"
There's no need to wildy overstandardize right away. Existing docs can freely refer to "GDShader", "Godot's shading language", or "Godot shaders" as they currently do. But in cases where a distinction does need to be made with GLSL, a formal name is good.
(If approved, I volunteer to make the initial changes to the docs, as well as look through the engine itself to find places that may need changing.)
If this enhancement will not be used often, can it be worked around with a few lines of script?
N/A
Is there a reason why this should be core and not an add-on in the asset library?
You cannot change the official name from the asset library.
The text was updated successfully, but these errors were encountered: