Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animation name in Your first 2D game #9958

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 15, 2024

@Calinou Calinou added bug cherrypick:4.2 cherrypick:4.3 area:getting started Issues and PRs related to the Getting Started section of the documentation topic:2d labels Sep 15, 2024
@mhilbrunner mhilbrunner merged commit ea5df15 into godotengine:master Sep 16, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you, merged.

@Calinou Calinou deleted the first-2d-game-fix-animation-name branch September 16, 2024 21:22
@Piralein
Copy link
Member

This change is wrong in my opinion.
The images are called playerGrey_up1.png, playerGrey_up2.png and playerGrey_walk1.png, playerGrey_walk2.png.

playerGrey_up[1/2] means playerGrey_up1.png and playerGrey_up2.png
playerGrey_walk[1/2] means playerGrey_walk1.png and playerGrey_walk2.png

Drag the two images for each animation, named...

@Dreyseth
Copy link

The file names are not the problem here. The issue is in readability of the text "[1/2]", which reads as "one OF two" rather than the intended "one AND two".

@mhilbrunner
Copy link
Member

Cherry-picked to 4.3 in #10038.

@Calinou
Copy link
Member Author

Calinou commented Oct 17, 2024

@Piralein @Dreyseth I initially didn't understand the problem that was raised (I thought the comment was pointing out a typo). This should be addressed by #10101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:getting started Issues and PRs related to the Getting Started section of the documentation bug cherrypick:4.2 topic:2d
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants