Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak animation file names to be less confusing in Creating the player scene #10101

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 17, 2024

It's more verbose, but it's easier to understand and doesn't rely on the reader knowing how to interpret the [1/2] part.

@Calinou Calinou added enhancement area:getting started Issues and PRs related to the Getting Started section of the documentation cherrypick:4.3 labels Oct 17, 2024
@Calinou Calinou force-pushed the player-scene-animation-tweak-names branch 2 times, most recently from b6b4ec0 to d28353f Compare October 17, 2024 13:11
…r scene

It's more verbose, but it's easier to understand and doesn't rely on
the reader knowing how to interpret the `[1/2]` part.
@Calinou Calinou force-pushed the player-scene-animation-tweak-names branch from d28353f to b364717 Compare October 17, 2024 13:11
Copy link
Member

@Piralein Piralein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still reads confusing for me, maybe a bullet list works better in this case

On the left is a list of animations. Click the ``default`` one and rename it to
``walk``. Then click the "Add Animation" button to create a second animation named
``up``.

Find the player images in the FileSystem dock - they're in the ``art``
folder you unzipped earlier.
Drag the two images for each animation,
into the **Animation Frames** side of the panel for the corresponding animation:

* ``playerGrey_walk1`` and ``playerGrey_walk2`` for the ``walk`` animation
* ``playerGrey_up1`` and ``playerGrey_up2`` for the ``up`` animation

or maybe the and between the 2 animations

@mhilbrunner
Copy link
Member

Thanks for following up on this, when cherry-picking the original I kinda agreed this could be improved further :)

@skyace65
Copy link
Contributor

skyace65 commented Dec 1, 2024

I agree with Piralein's suggestion.

@tetrapod00
Copy link
Contributor

We just got a duplicate PR (#10397) to fix the bug introduced in #9958. So I'm tempted to merge this as-is as a bugfix.

Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bugfix, and it's correct and readable as-is. If we want to make additional changes like Piralein's suggestion, it's possible to do that in the future.

@mhilbrunner mhilbrunner merged commit bdcf0de into godotengine:master Dec 10, 2024
1 check passed
@mhilbrunner
Copy link
Member

Seems reasonable, merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:getting started Issues and PRs related to the Getting Started section of the documentation bug cherrypick:4.3
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants