-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak animation file names to be less confusing in Creating the player scene #10101
Tweak animation file names to be less confusing in Creating the player scene #10101
Conversation
b6b4ec0
to
d28353f
Compare
…r scene It's more verbose, but it's easier to understand and doesn't rely on the reader knowing how to interpret the `[1/2]` part.
d28353f
to
b364717
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still reads confusing for me, maybe a bullet list works better in this case
On the left is a list of animations. Click the ``default`` one and rename it to
``walk``. Then click the "Add Animation" button to create a second animation named
``up``.
Find the player images in the FileSystem dock - they're in the ``art``
folder you unzipped earlier.
Drag the two images for each animation,
into the **Animation Frames** side of the panel for the corresponding animation:
* ``playerGrey_walk1`` and ``playerGrey_walk2`` for the ``walk`` animation
* ``playerGrey_up1`` and ``playerGrey_up2`` for the ``up`` animation
or maybe the and
between the 2 animations
Thanks for following up on this, when cherry-picking the original I kinda agreed this could be improved further :) |
I agree with Piralein's suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bugfix, and it's correct and readable as-is. If we want to make additional changes like Piralein's suggestion, it's possible to do that in the future.
Seems reasonable, merged. Thanks! |
It's more verbose, but it's easier to understand and doesn't rely on the reader knowing how to interpret the
[1/2]
part.