2D movement overview - Click-and-move - use actions

[HubbleCommand]

Changed the code sample for the Click-and-move section of the 2D movement overview page to use Actions instead of the InputEvent, to match the sample.

[AThousandShips]

The C# example should be updated accordingly

[HubbleCommand]

The C# example should be updated accordingly

I don't know if there is one? I can't see any mono in godot-docs-project-starters and there is no 2d movement starter in the mono demos.

[AThousandShips]

The example in the code right below:

godot-docs/tutorials/2d/2d_movement.rst

Lines 255 to 264 in 1508be4

	public override void _Input(InputEvent @event)
	{
	if (@event is InputEventMouseButton eventMouseButton)
	{
	if (eventMouseButton.ButtonIndex == MouseButton.Left && eventMouseButton.Pressed)
	{
	_target = GetGlobalMousePosition();
	}
	}
	}

[HubbleCommand]

The example in the code right below:

godot-docs/tutorials/2d/2d_movement.rst

Lines 255 to 264 in 1508be4

	public override void _Input(InputEvent @event)
	{
	if (@event is InputEventMouseButton eventMouseButton)
	{
	if (eventMouseButton.ButtonIndex == MouseButton.Left && eventMouseButton.Pressed)
	{
	_target = GetGlobalMousePosition();
	}
	}
	}

ah, I am blind, done!

Resolved

[skyace65]

We updated this code snippet 3 months ago in #9427 which is why it doesn't line up with what's in the demo project repository, it wasn't updated there. I need someone to explain to me why one method of getting input is better than the other, or better practice, before this can be merged, because I've just tested the old and new code and both work.

[HubbleCommand]

We updated this code snippet 3 months ago in #9427 which is why it doesn't line up with what's in the demo project repository, it wasn't updated there. I need someone to explain to me why one method of getting input is better than the other, or better practice, before this can be merged, because I've just tested the old and new code and both work.

From the documentation:

However, it is cleaner and more flexible to use the provided :ref:InputMap <class_InputMap> feature, which allows you to define input actions and assign them different keys

[HubbleCommand]

I don't know why #9197 says the previous InputMapping example didn't work. #9197 says it doesn't work in 4.2.1.stable. I just tested it and it does, using either the passed event variable or the Input global. It also works in 4.3.

The other parts of this page also use Actions with get_vector & get_axis in GDScript and C#, so I don't know why only that one was changed? It's also what's still in the start project, which still works.

[skyace65]

Thanks! And congrats on your first merged PR!

[mhilbrunner]

Cherry-picked to 4.3 in #10038.