Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the outdated "Click-and-move" example in the 2D movement tutorial #9427

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Update the outdated "Click-and-move" example in the 2D movement tutorial #9427

merged 1 commit into from
Jun 4, 2024

Conversation

mateuseap
Copy link
Contributor

What I Did

  • Updated both the GDScript and C# code versions of the "Click-and-move" example in the 2D movement tutorial.

Closes: #9197

AThousandShips
AThousandShips reviewed May 27, 2024
View reviewed changes
tutorials/2d/2d_movement.rst Outdated Show resolved Hide resolved
tutorials/2d/2d_movement.rst Outdated Show resolved Hide resolved
@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:2d labels May 27, 2024
@mateuseap
Update the outdated "Click-and-move" example in the 2D movement tutorial
4cba7b0 
Update both the GDScript and C# versions of the "Click-and-move" example in the 2D movement tutorial.
@mateuseap mateuseap requested a review from AThousandShips May 27, 2024 17:44
@mateuseap
Copy link
Contributor Author

I've updated the codes with your suggestions, @AThousandShips

skyace65
skyace65 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the GDScript and C# code and both work perfectly. Thanks!

@skyace65 skyace65 merged commit 7a4b927 into godotengine:master Jun 4, 2024
1 check passed
@skyace65 skyace65 mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyace65 skyace65 skyace65 approved these changes

@AThousandShips AThousandShips Awaiting requested review from AThousandShips

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:dotnet topic:2d
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Click-and-move example contains outdated input code
3 participants
@mateuseap @skyace65 @AThousandShips