Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for when navigation debug mesh will show #8917

Merged

Conversation

morganwesemann
Copy link
Contributor

Adds documentation for when the navigation debug mesh will show in navigation debug tools. Closes #8911.

@AThousandShips AThousandShips requested a review from a team February 7, 2024 10:37
@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:navigation labels Feb 7, 2024
@smix8
Copy link
Contributor

smix8 commented Feb 7, 2024

Debug shows other objects as well not just regions but I think we can generalize and shorten this by mentioning that any navigation debug visuals (and physics also for that matter) are currently based on nodes and the SceneTree.

If users work with the servers directly all changes and additions will not be visually reflected by the debug. The communication is one way from node to server, but not from server to node.

We already mention this in many class documentations for properties that if users update them with the server directly the node properties will stay outdated. There is a proposal to change that godotengine/godot-proposals#7208.

@morganwesemann
Copy link
Contributor Author

morganwesemann commented Feb 8, 2024

Debug shows other objects as well not just regions but I think we can generalize and shorten this by mentioning that any navigation debug visuals (and physics also for that matter) are currently based on nodes and the SceneTree.

If users work with the servers directly all changes and additions will not be visually reflected by the debug. The communication is one way from node to server, but not from server to node.

We already mention this in many class documentations for properties that if users update them with the server directly the node properties will stay outdated. There is a proposal to change that godotengine/godot-proposals#7208.

Thank you for your comment! I completely missed seeing that issue, thanks for pointing it out. I've updated my PR to simplify and generalize the addition. I understand if we choose not to add this given godotengine/godot-proposals#7208 exists.

@skyace65 skyace65 merged commit 316ba4b into godotengine:master Feb 13, 2024
1 check passed
@skyace65
Copy link
Contributor

Thanks! And congrats on your first merged PR!

@morganwesemann morganwesemann deleted the navigation-debug-mesh-documentation branch July 14, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:navigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation debug tools page does not make it clear to use NavigationRegion2D or NavigationRegion3D
4 participants