Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit 3D collision shapes #4073

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Edit 3D collision shapes #4073

merged 1 commit into from
Sep 28, 2020

Conversation

NathanLovato
Copy link
Contributor

@NathanLovato NathanLovato commented Sep 26, 2020 •
edited
Loading

  • Added a bullet list in the intro to summarize what's in the article
  • Passive -> direct voice
  • Remove parens in sentences
  • Tweak some sentences' wording
  • Fix typos
  • Minor grammar fixes
  • Add missing Oxford commas

@NathanLovato NathanLovato force-pushed the edit/3d-collision-shapes branch from 98aab90 to 5c147d8 Compare September 26, 2020 14:36
@NathanLovato
Copy link
Contributor Author

NathanLovato commented Sep 26, 2020 •
edited
Loading

Let me know if you'd prefer me to put comments and suggestions, but after doing it for #4058, I think it's much more efficient if we work like that: one writing pass, one person editing. People are welcome to do that with my PRs too, editing directly.

@NathanLovato
Edit 3D collision shapes
5571352 
- Passive -> direct voice
- Remove parens in sentences
- Tweak some sentences' wording
- Fix typos
- Add missing Oxford commas
@NathanLovato NathanLovato force-pushed the edit/3d-collision-shapes branch from 5c147d8 to 5571352 Compare September 26, 2020 17:22
@NathanLovato NathanLovato mentioned this pull request Sep 26, 2020
Merged
@Calinou
Copy link
Member

Calinou commented Sep 26, 2020

Let me know if you'd prefer me to put comments and suggestions, but after doing it for #4058, I think it's much more efficient if we work like that: one writing pass, one person editing. People are welcome to do that with my PRs too, editing directly.

It's fine to do it this way too 🙂

@akien-mga akien-mga merged commit 8438f07 into godotengine:master Sep 28, 2020
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov left review comments

@Calinou Calinou Awaiting requested review from Calinou

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NathanLovato @Calinou @akien-mga @YuriSizov