Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a random number generation tutorial #4024

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 17, 2020

This closes #2436.

@Calinou Calinou force-pushed the add-random-number-generation-tutorial branch from d11155d to 1fb1eed Compare September 17, 2020 13:28
@NathanLovato
Copy link
Contributor

I just left comments because it's a solid article overall. If you're fine with the idea, I'd add edits to get closer to the writing guidelines on top of your work, as in #4073

@Calinou Calinou force-pushed the add-random-number-generation-tutorial branch from 1fb1eed to 7d9ffa7 Compare September 30, 2020 14:42
@Calinou
Copy link
Member Author

Calinou commented Sep 30, 2020

Feel free to merge and edit later 🙂

@NathanLovato
Copy link
Contributor

Seems I can directly edit the doc and commit to the PR. I'll do so later.

Remove parens, passive voice -> direct voice, fix some typos, simplify some of the language, and add a short intro listing what the reader will learn
@NathanLovato
Copy link
Contributor

The overview of some common functions makes sense after a second read and checking the class reference: it's much more convenient for the reader than having to open two pages and searching for the functions.

@NathanLovato NathanLovato merged commit 8fa58f1 into godotengine:master Sep 30, 2020
@NathanLovato
Copy link
Contributor

Thanks for your work!

@Calinou Calinou deleted the add-random-number-generation-tutorial branch August 3, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Randomness tutorial
2 participants