Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of source_color with hint_depth_texture #10406

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix usage of source_color with hint_depth_texture #10406

merged 1 commit into from
Dec 16, 2024

Conversation

tetrapod00
Copy link
Contributor

Fix #10402.

I checked all three of the screen texture hints and this is all I could find.

@tetrapod00 tetrapod00 added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:shaders cherrypick:4.3 labels Dec 14, 2024
@tetrapod00 tetrapod00 requested a review from a team December 14, 2024 03:37
paddy-exe
paddy-exe approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhilbrunner mhilbrunner merged commit 8b36717 into godotengine:master Dec 16, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you!

@tetrapod00 tetrapod00 deleted the fix-source-color branch December 16, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddy-exe paddy-exe paddy-exe approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug cherrypick:4.3 topic:shaders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent usage of source_color with hint_depth_texture
3 participants
@tetrapod00 @mhilbrunner @paddy-exe