Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent usage of source_color with hint_depth_texture #10402

Closed
tetrapod00 opened this issue Dec 12, 2024 · 1 comment · Fixed by #10406
Closed

Inconsistent usage of source_color with hint_depth_texture #10402

tetrapod00 opened this issue Dec 12, 2024 · 1 comment · Fixed by #10406
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:shaders

Comments

@tetrapod00
Copy link
Contributor

Your Godot version:
4.4
Issue description:
https://docs.godotengine.org/en/latest/tutorials/shaders/advanced_postprocessing.html#depth-texture uses source_color when accessing hint_depth_texture.
https://docs.godotengine.org/en/latest/tutorials/shaders/screen-reading_shaders.html#depth-texture does not use source_color when accessing hint_depth_texture.
Only one of these should be right (in the renderers where source_color matters).

There may also be other usages, and we should also check and make sure that hint_screen_texture and hint_normal_roughness_texture usages are consistent in other pages, too.

URL to the documentation page:
See above

@tetrapod00 tetrapod00 added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:shaders labels Dec 12, 2024
@clayjohn
Copy link
Member

That must be a copy-paste typo. I don't think source_color is a valid hint for the depth texture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:shaders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants