Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Version Compatibility" section in "What is GDExtension" #10404

Merged

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Dec 12, 2024

This attempts to improve the "Version Compatibility" section on this page

There is a warning that talks about version compatibility at the top: in this PR, I've reduced that warning to just talk about how GDExtension is experimental, and moved the version compatibility details down into the "Verson Compatibility" section.

I also expanded a bit on the note about using engine builds with double precision floats, adding:

  • That you need to use generate a extension_api.json (which is something folks frequently miss), and
  • That, in general, you should generate an extension_api.json anytime you're using a custom engine build (not just for double precision floats)

@dsnopek dsnopek requested a review from paddy-exe December 12, 2024 22:51
@dsnopek dsnopek added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:gdextension labels Dec 12, 2024
Copy link
Contributor

@tetrapod00 tetrapod00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for style and not seeing anything obviously wrong, but I'm not a GDExtension expert

@dsnopek dsnopek force-pushed the gdextension-version-compatibility branch from ddd6e5d to 6582877 Compare December 12, 2024 23:19
Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tetrapod00 tetrapod00 merged commit 19f5643 into godotengine:master Dec 13, 2024
1 check passed
@tetrapod00
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.3 enhancement topic:gdextension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants