-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example of GDExtension written pure C #10403
Conversation
403d8d9
to
6bd51a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed for grammar, style, and formatting. Generally looks good, overall very clear. I made a bunch of style nitpick suggestions.
FYI in the docs repo we currently only use milestones for PRs that only apply to the latest minor version, in this case (Maybe we should use them more. But we don't 🤷 ) |
fecf654
to
e373059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, read it twice for proofreading, and approving the concept of this tutorial. I didn't have time to actually test any of it, but I'll trust vnen and dsnopek on the technical accuracy :)
e373059
to
175ba7e
Compare
Per my original note in the description:
I've cloned vnen's repo and tested all the code updates that were made to the tutorial - you can find my updated version here: https://github.com/dsnopek/gdextension-c-example/tree/drs So, the current code in the tutorial is all tested as working now :-) We should probably move the complete code to somewhere official, although, I'm not exactly sure where? |
175ba7e
to
1d33564
Compare
1d33564
to
874b279
Compare
We have (had) https://github.com/godotengine/gdnative-demos once upon a time. It may make sense to createa |
Thank you! Also pinged Akien about the repo in #gdextension on RC. |
This salvages @vnen's PR #8751
I applied almost all the suggestions there (I disagreed with a small handful of them :-)).
I think vnen had a repo with the full project somewhere which I need to dig up, so I can update it for the few code changes here and test that everything actually works as written.