-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a 3D antialiasing demo #743
Add a 3D antialiasing demo #743
Conversation
We should keep our eyes open for a cc0 licenced model with a more complex profile. Something thin like a powerline is important to show how well different AA techniques preserve shape. |
ac6d6fb
to
b521095
Compare
Rebased with TAA support. This should now be ready to be merged. |
Before merging we really need to use a better model. Cubes are not sufficient to clearly show the differences between AA methods. Consider using something like this https://polyhaven.com/a/dutch_ship_medium which has a good amount of thin geometry. |
b521095
to
89c2d94
Compare
Done, I added this model in the test scene (with 1K textures to keep file sizes low). Textures are blurry when up close in 2560×1440, but it still demonstrates the effect of antialiasing well. |
51caead
to
462a76d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! It was lots of fun to step through and it does a nice job of covering a wide range of edge cases.
I will leave it up to someone with more knowledge about the demos to approve with respect to organization/code quality.
462a76d
to
8598453
Compare
8598453
to
9dbd05a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you, this demo is super polished.
I pushed some updates, including some minor changes to the camera script and default camera angle, an updated screenshot, renaming the scene and script, moving textures to a subfolder, and optimizing PNG files using oxipng
.
This demo showcases the various 3D antialiasing techniques supported by Godot. Many potentially problematic cases for TAA such as godotengine/godot#69493 are also included, so this will be used as a testing project for the purpose of improving Godot's TAA implementation.
Preview
TODO (in future PRs)