Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection of sdk style projects #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xyotic
Copy link

@Xyotic Xyotic commented Sep 6, 2022

This PR adds detection of sdk style projets inside the IsGodotProject() method.

To make this work I had to add "[ProvideAutoLoad(UIContextGuids80.NoSolution, PackageAutoLoadFlags.BackgroundLoad)]" to the GodotPackage class to initialize the extension right on startup.
Otherwise OnAfterOpenProject() wont get called.

This PR can be built upon to hopefully make GodotTools.IdeMessaging.Client work with Godot 4

@Xyotic
Copy link
Author

Xyotic commented Sep 6, 2022

This should help fixing #10

@neikeq
Copy link
Contributor

neikeq commented Sep 6, 2022

This doesn't fix the run configurations not showing up for sdk style projects, right? If so, what's the benefit of doing this?

@Xyotic
Copy link
Author

Xyotic commented Sep 6, 2022

This is just to detect if a godot project is open in VisualStudio.

Since we can start and attach the debugger via .csproj, and are able to add Launch & PlayInEditor via launchsettings.json (see #10), I think all that is left is to connect the Client to the engine again.

@neikeq
Copy link
Contributor

neikeq commented Sep 6, 2022

Is this not working now with dfdea8a? If it is working with those commands, I would prefer not to make the plugin autoload.

@Xyotic
Copy link
Author

Xyotic commented Sep 6, 2022

Maybe we can work around the auto load... would need to check that out.
I think we should try to make it work with the debug target selection. Its just more natural to work with that in visual studio than look for a debug option inside a toolbar menu

Edit: We could still use the work of dfdea8a to add the necessary configurations to the Godot projects files

@GeorgeS2019
Copy link

dfdea8a : this option still needs much brainstorming how best to feed the right parameters and how to best organize the menu and submenu. So far, there is no further discussions.

@Commander-Firestrike
Copy link

I think the best way of supporting SDK Style projects is by using the VS Project System. According to this repo, DotNET Core projects use this system internally in Visual Studio now

@neikeq
Copy link
Contributor

neikeq commented Sep 17, 2022

The problem is getting that to work. Last time I tried I had no success.

@Xyotic
Copy link
Author

Xyotic commented Sep 17, 2022

I tried it as well. I got it to build and start. But it doesnt seem to detect your project.
I haven't dug deeper yet, but with the lack of proper working samples and no real documentation, it will be pretty difficult to get this working...

@GeorgeS2019
Copy link

GeorgeS2019 commented Sep 17, 2022

With pure .Net6 project this time, i mean obviously Godot4 , perhaps the chance will be better?

@Xyotic
Copy link
Author

Xyotic commented Sep 17, 2022

I tried it with a fresh .net6 project. Without Godot.
There are others that having the same issue. There are open issues at this repository that arent getting any response.

@Commander-Firestrike
Copy link

Yeah unfortunately the docs for "Extending a project type" have been "TODO" for years 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants