Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-existent Signals/Connections #64

Closed
BHSDuncan opened this issue Nov 22, 2021 · 7 comments · Fixed by godot-escoria/escoria-demo-game#470
Closed

Non-existent Signals/Connections #64

BHSDuncan opened this issue Nov 22, 2021 · 7 comments · Fixed by godot-escoria/escoria-demo-game#470
Labels
bug Something isn't working
Milestone
4.0.0

Comments

@BHSDuncan
Copy link
Collaborator

Please make sure you talk to the community before creating an issue.

Describe the bug
Escoria is producing errors (but not crashing) in the following locations:

  • inventory_ui.gd: The disconnection to "input_event" is saying that that there is no such connection to disconnect.
  • esc_player.gd: There is a small handful of signals being disconnected in remove_item_by_id, of which several are apparently for signals that don't exist. Maybe they changed names or were removed?

To Reproduce
Steps to reproduce the behavior:

  1. Create a game with inventory items.
  2. Add and then remove any inventory item.

Expected behavior
Errors shouldn't be thrown.

Versions

  • Escoria: 4.0.0-alpha.15
  • Godot: 3.3.4
@BHSDuncan BHSDuncan added the bug Something isn't working label Nov 22, 2021
@StraToN StraToN added this to the 4.0.0 milestone Nov 22, 2021
@StraToN
Copy link

StraToN commented Nov 22, 2021

I remarked we connect many signals that are meant to be removed after being received once. Godot allows us to create connections that are automatically removed after having been received.

@BHSDuncan
Copy link
Collaborator Author

Ok, but can anything be done for the errors showing up when running?

@StraToN
Copy link

StraToN commented Nov 22, 2021

@BHSDuncan yes, definitely. Actually I removed some of these errors already, but I know there are some left. We definitely want to have them gone.

dploeger added a commit to godot-escoria/escoria-demo-game that referenced this issue Nov 26, 2021
@dploeger
fix: Fixes smaller things
4f837dc 
Fix player sprite not showing correct idle animation after animations change in room switch
Remove some more error outputs (godot-escoria/escoria-issues#64)
Fix verbs menu button selection when input mode is not all
@dploeger dploeger mentioned this issue Nov 26, 2021
Merged
dploeger added a commit to godot-escoria/escoria-demo-game that referenced this issue Nov 26, 2021
@dploeger
feat: Several fixes and optimizations
bcfc5e7 
This fixes another error message of godot-escoria/escoria-issues#64
This optimizes how UI and dialog managers register themselves with Escoria
This fixes another "character is at position, but action still isn't carried out"
This fixes click bubbling down to multiple items triggering different actions
This removes the "tooltip follows focus" setting because it solemly was a simplemouse feature
This optimizes the registering of settings
@dploeger dploeger mentioned this issue Nov 26, 2021
Merged
@dploeger
Copy link
Collaborator

@BHSDuncan What did you mean with the "disconnects to input_event" in inventory_ui.gd I can't find any of those.

@dploeger
Copy link
Collaborator

Ohh. I think you mixed up the files, right? The input_event thing is for esc_player.gd

@dploeger
Copy link
Collaborator

THAT was fixed in godot-escoria/escoria-demo-game#465

dploeger added a commit to godot-escoria/escoria-demo-game that referenced this issue Nov 28, 2021
@dploeger
fix: Safety guards for disconnects
4714629 
fixes godot-escoria/escoria-issues#64
@dploeger dploeger mentioned this issue Nov 28, 2021
Merged
@dploeger
Copy link
Collaborator

Added a PR to fix the remaining thing.

There still might be errors or warnings somewhere, but let's close this issue after merging the PR at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

fix: Safety guards for disconnects godot-escoria/escoria-demo-game
3 participants
@dploeger @StraToN @BHSDuncan