feat: Several fixes and optimizations #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes another error message of godot-escoria/escoria-issues#64 This optimizes how UI and dialog managers register themselves with Escoria This fixes another "character is at position, but action still isn't carried out" This fixes click bubbling down to multiple items triggering different actions This removes the "tooltip follows focus" setting because it solemly was a simplemouse feature This optimizes the registering of settings
StraToN
reviewed
Nov 27, 2021
| @@ -130,7 +130,7 @@ func run() -> bool: | |||
| self.comparison_value: | |||
| return_value = true | |||
| elif self.comparison == COMPARISON_ACTIVITY and \ | |||
| escoria.object_manager.has_object(global_name) and \ | |||
| escoria.object_manager.has(global_name) and \ | |||
There was a problem hiding this comment.
Oops, I may responsible for this error :/
StraToN
approved these changes
Nov 27, 2021
|
All good to me ! Thanks! |
balloonpopper
pushed a commit
to balloonpopper/escoria-demo-game
that referenced
this pull request
Feb 13, 2022
Co-authored-by: Dennis Ploeger <[email protected]>
bolinfest
added a commit
to bolinfest/escoria-demo-game
that referenced
this pull request
Mar 21, 2022
…/command_directories It appears that the settings `escoria/esc/command_paths` and `escoria/main/command_directories` have duplicate purposes. Unfortunately, they are read in different places, so if you add a directory to one setting, it will not be present in the other. Specifically, `ESCCompiler` read from `escoria/esc/command_paths` while `ESCCommand` and `ESCCommandRegistry` read from `escoria/main/command_directories`. As the `COMMAND_PATHS` constant had no references, it seemed more appropriate to delete. The `escoria/esc/command_paths` appears to have been set initially in `project.godot` as part of: godot-escoria#467
StraToN
pushed a commit
that referenced
this pull request
Mar 23, 2022
…/command_directories It appears that the settings `escoria/esc/command_paths` and `escoria/main/command_directories` have duplicate purposes. Unfortunately, they are read in different places, so if you add a directory to one setting, it will not be present in the other. Specifically, `ESCCompiler` read from `escoria/esc/command_paths` while `ESCCommand` and `ESCCommandRegistry` read from `escoria/main/command_directories`. As the `COMMAND_PATHS` constant had no references, it seemed more appropriate to delete. The `escoria/esc/command_paths` appears to have been set initially in `project.godot` as part of: #467
StraToN
pushed a commit
to godot-escoria/escoria-core
that referenced
this pull request
Mar 23, 2022
…/command_directories It appears that the settings `escoria/esc/command_paths` and `escoria/main/command_directories` have duplicate purposes. Unfortunately, they are read in different places, so if you add a directory to one setting, it will not be present in the other. Specifically, `ESCCompiler` read from `escoria/esc/command_paths` while `ESCCommand` and `ESCCommandRegistry` read from `escoria/main/command_directories`. As the `COMMAND_PATHS` constant had no references, it seemed more appropriate to delete. The `escoria/esc/command_paths` appears to have been set initially in `project.godot` as part of: godot-escoria/escoria-demo-game#467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes another error message of godot-escoria/escoria-issues#64
This optimizes how UI and dialog managers register themselves with Escoria
This fixes another "character is at position, but action still isn't carried out"
This fixes click bubbling down to multiple items triggering different actions
This removes the "tooltip follows focus" setting because it solemly was a simplemouse feature
This optimizes the registering of settings