-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move HeadingToolbar controls to block toolbar #1352
Conversation
Looks like the following test will need to be updated. I'd appreciate any extra hands for this! :)
|
Gutenberg is implementing this here: WordPress/gutenberg#20246 |
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working well on my end. Approved.
Description
This PR moves the
HeadingToolbar
component that we use in our blocks which manipulate headings within InnerBlocks (Services, Features). Instead of utilizing the Sidebar Settings, the controls are moved to the block toolbar.There is already discussion around removing the sidebar control within the core Heading block. This aligns with the pending experience.
Screenshots
Before:
After:
Types of changes
New feature (non-breaking change which adds functionality), while removing an older feature (including the sidebar control).
How has this been tested?
Checklist: