Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX: Convert HeadingToolbar to ButtonGroup #20126

Closed
richtabor opened this issue Feb 9, 2020 · 7 comments
Closed

UI/UX: Convert HeadingToolbar to ButtonGroup #20126

richtabor opened this issue Feb 9, 2020 · 7 comments
Labels
Needs Design Feedback Needs general design feedback.

Comments

@richtabor
Copy link
Member

In order to bring more consistency across controls, as originally discussed in #19904, let's consider employing the ButtonGroup control, instead of a one-off HeadingToolbar component we're currently using, within the Heading block.

Here's what we currently have:
toolbar-1

Here's what it would look like, as a ButtonGroup:
toolbar-2

@richtabor richtabor added the Needs Design Feedback Needs general design feedback. label Feb 9, 2020
@kevinkovadia
Copy link

oh yes, looks better.

@kevinkovadia
Copy link

just an idea, Can we use adjust height H1 icon as same font size and so on as shown in attached image.
WP

can this increase visual appeal?

@shaunandrews
Copy link
Contributor

I wonder if we need to have this option in both the sidebar and the toolbar? It seems with the toolbar we could add all the options and just get rid of the sidebar options.

image

--

Looking towards the new block UI, I think we could basically take the sidebar component and use in a popover:

image

@richtabor
Copy link
Member Author

I wonder if we need to have this option in both the sidebar and the toolbar?

That's an interesting proposition. I'm down for decluttering for sure.

I'm curious if we could get some user testing around this, to see if users understand that they can change the heading level via the toolbar H{level} label, or they need to see the label/array of sizes first (like within the sidebar).

@karmatosed
Copy link
Member

I think moving to the toolbar as @shaunandrews suggests make a bit more sense visually and also brings in the iterated UI.

As far as user experience goes, I do think in the sidebar there is even more invisibility than being in the toolbar.

@paaljoachim
Copy link
Contributor

paaljoachim commented May 19, 2020

I will also mention this PR:
"Heading block: use toolbar exclusively for heading level control "
#20246

@mapk
Copy link
Contributor

mapk commented May 19, 2020

After today's design team triage in Slack, it was decided to close this issue due to the above mentioned PR. Once the controls get merged into the block toolbar, it would be a good idea to create a new PR that removes these controls from the sidebar. That makes this issue obsolete.

@mapk mapk closed this as completed May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

No branches or pull requests

6 participants