-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/UX: Convert HeadingToolbar to ButtonGroup #20126
Comments
oh yes, looks better. |
That's an interesting proposition. I'm down for decluttering for sure. I'm curious if we could get some user testing around this, to see if users understand that they can change the heading level via the toolbar |
I think moving to the toolbar as @shaunandrews suggests make a bit more sense visually and also brings in the iterated UI. As far as user experience goes, I do think in the sidebar there is even more invisibility than being in the toolbar. |
I will also mention this PR: |
After today's design team triage in Slack, it was decided to close this issue due to the above mentioned PR. Once the controls get merged into the block toolbar, it would be a good idea to create a new PR that removes these controls from the sidebar. That makes this issue obsolete. |
In order to bring more consistency across controls, as originally discussed in #19904, let's consider employing the
ButtonGroup
control, instead of a one-offHeadingToolbar
component we're currently using, within the Heading block.Here's what we currently have:
![toolbar-1](https://user-images.githubusercontent.com/1813435/74107630-5f249300-4b2f-11ea-8fca-55ec735c79be.jpg)
Here's what it would look like, as a
![toolbar-2](https://user-images.githubusercontent.com/1813435/74107608-2edcf480-4b2f-11ea-957b-269db1cba2f5.jpg)
ButtonGroup
:The text was updated successfully, but these errors were encountered: