Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for config files in downloader. #404

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Add support for config files in downloader. #404

merged 3 commits into from
Jul 19, 2023

Conversation

s-l-teichmann
Copy link
Contributor

First step towards storing options in configuration files.

Part of #396

ThomasJunk
ThomasJunk previously approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works.

cmd/csaf_downloader/config.go Show resolved Hide resolved
cmd/csaf_downloader/config.go Outdated Show resolved Hide resolved
JanHoefelmeyer
JanHoefelmeyer previously approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-l-teichmann s-l-teichmann dismissed stale reviews from JanHoefelmeyer and ThomasJunk via 7dda208 July 19, 2023 08:36
ThomasJunk
ThomasJunk approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@ThomasJunk ThomasJunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JanHoefelmeyer
JanHoefelmeyer approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@JanHoefelmeyer JanHoefelmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s-l-teichmann s-l-teichmann merged commit 8630e8b into main Jul 19, 2023
@s-l-teichmann s-l-teichmann deleted the downloader-cfg branch July 19, 2023 08:49
@JanHoefelmeyer JanHoefelmeyer mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasJunk ThomasJunk ThomasJunk approved these changes

@JanHoefelmeyer JanHoefelmeyer JanHoefelmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s-l-teichmann @ThomasJunk @JanHoefelmeyer