Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config file for downloader and checker #396

Closed
JanHoefelmeyer opened this issue Jul 7, 2023 · 2 comments
Closed

Add Config file for downloader and checker #396

JanHoefelmeyer opened this issue Jul 7, 2023 · 2 comments

Comments

@JanHoefelmeyer
Copy link
Contributor

Allow the configuration of the CSAF-checker and CSAF-downloader to be read via a seperate config file, while maintaining the option for command line parameters.

@JanHoefelmeyer
Copy link
Contributor Author

JanHoefelmeyer commented Aug 2, 2023

The functionality of using a config file for the csaf_downloader was implemented via:
#404 (Support for config files in downloader)

After deciding that the TOML file format offers advantages over the previously used format, the switch to TOML files as config files was made via:
#405 (Use TOML as config file in downloader)

Similarly, a TOML config file option was introduced for the checker via:
#412

Both tools will now search for a TOML file within a few set locations, unless a command line parameter explicitly points towards a location where one should be found. Any TOML file option can be overridden via command line parameters and they can be used to complement each other or used exclusively.

How to use these TOML files is written within their respective tools documentation:

Csaf_downloader: https://github.com/csaf-poc/csaf_distribution/blob/main/docs/csaf_downloader.md

Csaf_checker: https://github.com/csaf-poc/csaf_distribution/blob/main/docs/csaf_checker.md

Thus, this issue should be completely implemented.

@s-l-teichmann
Copy link
Contributor

This is now fully implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants