Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.5.0 #1047

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Release v1.5.0 #1047

merged 2 commits into from
Jan 7, 2020

Conversation

julienschmidt
Copy link
Member

@julienschmidt julienschmidt commented Jan 3, 2020

@julienschmidt julienschmidt added this to the v1.5.0 milestone Jan 3, 2020
@julienschmidt julienschmidt mentioned this pull request Jan 3, 2020
@julienschmidt
Copy link
Member Author

Should the build tags of conncheck rather be opt-in instead of op-out?

Current build tag: // +build !windows,!appengine

This might fail to compile on some platforms, or not?

@shogo82148
Copy link
Contributor

you are right. it fails on plan9.

I wrote very simple compile checker. https://gist.github.com/shogo82148/a7a61b7a1652bff07fc0dfd07ceb2122

The following is an abstract of the result for current master branch b66d043

$ENV{GOOS}="plan9"; $ENV{GOARCH}="amd64";
# github.com/go-sql-driver/mysql
./conncheck.go:42:15: undefined: syscall.EAGAIN
./conncheck.go:42:40: undefined: syscall.EWOULDBLOCK

@shogo82148 shogo82148 mentioned this pull request Jan 5, 2020
5 tasks
@julienschmidt
Copy link
Member Author

I wrote very simple compile checker. https://gist.github.com/shogo82148/a7a61b7a1652bff07fc0dfd07ceb2122

We should maybe add a Travis job for that

@julienschmidt julienschmidt force-pushed the changelog branch 4 times, most recently from 2c35580 to a3c4d20 Compare January 6, 2020 23:36
@vmg
Copy link
Contributor

vmg commented Jan 7, 2020

Hi @julienschmidt! Just came back from my holidays. How can I help with the release process? I see you already wrote the changelog notes. 🙇

@julienschmidt
Copy link
Member Author

#1054 and this PR still need a review and must be merged. Other than that, I think we're ready to tag the release. 🎉

Copy link
Contributor

@vmg vmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@julienschmidt julienschmidt merged commit 17ef3dd into master Jan 7, 2020
@julienschmidt julienschmidt deleted the changelog branch January 7, 2020 16:34
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
* CHANGELOG: include v1.4.1

* Release v1.5.0
tz70s pushed a commit to tz70s/mysql that referenced this pull request Sep 5, 2020
* CHANGELOG: include v1.4.1

* Release v1.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants