Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.0 #948

Closed
methane opened this issue Apr 4, 2019 · 14 comments
Closed

v1.5.0 #948

methane opened this issue Apr 4, 2019 · 14 comments
Milestone

Comments

@methane
Copy link
Member

methane commented Apr 4, 2019

I merged #943, which solves critical (race) issue #903.

@julienschmidt would you create a new release? Or may I do it?

Since the fix is just committed on master branch, I think it's safe to wait about week
to make new release. Some users will test master branch. So there will be feedback
if there is any regression.

@julienschmidt
Copy link
Member

So far those minor releases were bugfix releases. We have some more changes since the last release. I'd say we make a (small) 1.5.0 release instead.

But I agree, we should tag a new release soon.

@julienschmidt julienschmidt added this to the v1.5.0 milestone Apr 15, 2019
@sagikazarmark
Copy link

Is there an ETA for the new version?

@vmg
Copy link
Contributor

vmg commented Aug 22, 2019

Hi folks, any chances we could tag a new version of the driver? We've merged quite a few critical bugs since the previous version and no breaking changes. Tagging a new version would be important I believe.

@vmg
Copy link
Contributor

vmg commented Sep 24, 2019

Folks, it's been almost a year since the last minor release of the library. Please, could we tag a release with the many bugfixes that have landed in master since then?

@julienschmidt julienschmidt changed the title v1.4.2 v1.5.0 Sep 30, 2019
@mbyio
Copy link

mbyio commented Nov 7, 2019

I see there are a few issues still included in the v1.5.0 milestone, but there are some features, like the ability to clone a config, which seem to be ready now. Is there any way we can do a release to at least get some of those features (and other bug fixes) out?

@Delphier
Copy link

Delphier commented Dec 9, 2019

When released?

@colega
Copy link

colega commented Dec 10, 2019

v1.4.1 was released a while ago here: 72cd26f

But it's not in master branch.

We're trying to pin this dependency to the latest master commit (15462c1) but golang understands that the latest master version is v1.4.0 and creates a pseudo version v1.4.1-0.20191121062641-15462c1d60d4 which is later replaced by other dependencies depending on v1.4.1 which is highet than the pseudo version. Since v1.4.1 is not in master, we can't point to a pseudo-version v1.4.2-0.20191121062641-15462c1d60d4 either because:

go: github.com/go-sql-driver/[email protected]: invalid pseudo-version: revision 15462c1d60d4 is not a descendent of preceding tag (v1.4.1)

Please, release the v1.5.0 or v1.4.2 to make latest changes available as dependencies.

(We know we can add a replace directive but that was our last solution)

@vmg
Copy link
Contributor

vmg commented Dec 10, 2019

@julienschmidt: It seems like all the maintainers for the driver have been very busy lately. Since I have time to work on this, and I have contributed most of the functionality/fixes that will be included in the release, would you like me to work on actually preparing the release any fixing any blockers we may have? Please let me know, this is a priority for us and I can allocate as much time as required to make the release happen. Thank you!

@methane
Copy link
Member Author

methane commented Dec 11, 2019

@vmg Would you create a PR like #809?

@vmg
Copy link
Contributor

vmg commented Dec 11, 2019

Yes! I'll get to it ASAP.

@methane
Copy link
Member Author

methane commented Dec 11, 2019

FYI, I want to merge #1017 and #1016 in v1.5.0.
We can ignore Go 1.9 when fixing bugs in the future v1.5.x.

@joshprzybyszewski-wf
Copy link

👋 Just checking in for an update on the release. Looks like both of those PRs are merged: ETA?

@julienschmidt
Copy link
Member

julienschmidt commented Jan 3, 2020

(That was the wrong button)

Within the next 72h, if we encounter no further issues.

@vmg: I'll contact you privately. If this is a priority for you, I'd be awesome to have you in the team of maintainers. So far everyone here is, to the best of my knowledge, just working on it (or not) in their free time.

@julienschmidt
Copy link
Member

Continue here: #1047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants