Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use background context when KILL last connection #718

Merged
merged 2 commits into from
Jul 18, 2022
Merged

use background context when KILL last connection #718

merged 2 commits into from
Jul 18, 2022

Conversation

D3Hunter
Copy link
Contributor

to make #411 work, we need to use background context since b.ctx is already cancelled when we create another connection to kill last conn in b.close

@lance6716 lance6716 merged commit c855c26 into go-mysql-org:master Jul 18, 2022
@D3Hunter D3Hunter deleted the fix branch July 18, 2022 09:40
@lance6716 lance6716 changed the title use background as base ctx in context.WithTimeout use background context when KILL last connection Jul 18, 2022
@lance6716 lance6716 mentioned this pull request Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D3Hunter @lance6716