Fix unclosed conn, shutdown errors #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @GregoryIan |
siddontang
reviewed
Aug 28, 2019
siddontang
reviewed
Aug 28, 2019
IANTHEREAL
reviewed
Aug 30, 2019
IANTHEREAL
reviewed
Aug 30, 2019
Closing a canal by calling Close() results in errors as described in #273 [1]. Fix that by explicitly ignoring context cancellation as it's not really an error, but an expected part of Close(). Also fix the unclosed connection described in #361 [2] by using a separate connection to kill the binlog streamer. [1] #273 [2] #361 This closes #273. This closes #361.
|
LGTM |
|
@siddontang PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing a canal by calling Close() results in errors as described in #273.
Fix that by explicitly ignoring context cancellation as it's not really
an error, but an expected part of Close().
Also fix the unclosed connection described in #361 by using a
separate connection to kill the binlog streamer.