fix: go mod vendor #280
Merged
fix: go mod vendor #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwaller
approved these changes
Apr 19, 2020
Co-Authored-By: Peter Waller <[email protected]>
Co-Authored-By: Peter Waller <[email protected]>
Co-Authored-By: Peter Waller <[email protected]>
Co-Authored-By: Peter Waller <[email protected]>
|
accepted your suggestions. |
|
Thanks! |
pwaller
pushed a commit
that referenced
this pull request
Nov 1, 2020
As with the fix applied in #280.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #251
add dummy files to ensure c source is maintained transparently.
why this works vs #258 because // +build ignore is treated specially by golangs toolchain and its necessary to import the packages for them to be maintained.
I'm only doing this for v3.3 because that is all I require for my use case atm. Someone else can pick up the other versions if/when necessary.